[FXC-3564][FXC-979] ForceOutput and its stopping criterion #1519

angranl-flex · 2025-10-21T19:13:11Z

No description provided.

flow360/component/simulation/outputs/output_fields.py

flow360/component/simulation/outputs/outputs.py

benflexcompute · 2025-12-11T23:52:31Z

@codex review the PR

chatgpt-codex-connector · 2025-12-11T23:52:37Z

To use Codex here, create a Codex account and connect to github.

benflexcompute · 2025-12-11T23:54:19Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Flow360/flow360/component/simulation/translator/solver_translator.py

Lines 970 to 974 in f7b6ddb

    
           if has_instance_in_list(outputs, SurfaceIntegralOutput): 
        
               process_user_variables_for_integral(outputs) 
        
               integral_output = translate_monitor_output( 
        
                   outputs, SurfaceIntegralOutput, inject_surface_list_info 
        
               )

ForceOutput monitors are dropped from solver JSON

The translator still builds monitorOutput only from ProbeOutput and SurfaceIntegralOutput; there is no branch anywhere in get_solver_json that serializes the newly added ForceOutput monitor type (now part of MonitorOutputType). Any ForceOutput configured in SimulationParams will be silently omitted from the solver JSON, so total force coefficients and any stopping criteria based on them will never be produced.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

flow360/component/simulation/outputs/outputs.py

benflexcompute · 2025-12-11T23:56:53Z

flow360/component/simulation/outputs/outputs.py

+                or validation_info.physics_model_dict is None
+                or validation_info.physics_model_dict.get(model) is None
+            ):
+                raise ValueError("The model does not exist in simulation params' models list.")


I think this should be similarly done as the materialization function for the text expressions. Ad-hoc deserialization will make these 2 models independent which causes issue. Will this impact anything?

flow360/component/simulation/outputs/outputs.py

flow360/component/simulation/translator/solver_translator.py

…re expanded before validation

…ing criterion

…ng criterion check

…andard_deviation" and "range"

…the global validation context.

…iterion when it does not exist in outputs list

…entation

…he related translator and validation unit test

benflexcompute · 2025-12-17T00:15:25Z

flow360/component/simulation/validation/validation_context.py

+            # Check if required context attributes are available
+            if required_context:
+                for attr_name in required_context:
+                    if not hasattr(param_info, attr_name) or getattr(param_info, attr_name) is None:


The first criteria should raise. It indicates a bug.

Added ValueError and unit test.

…test

angranl-flex force-pushed the angran/forceOutput branch from c87d8f8 to a611fc9 Compare October 22, 2025 14:37

benflexcompute marked this pull request as draft October 22, 2025 15:46

angranl-flex force-pushed the angran/forceOutput branch 4 times, most recently from 0c3f55f to 48ac55a Compare October 28, 2025 16:03

angranl-flex changed the base branch from main to develop October 30, 2025 14:26

angranl-flex marked this pull request as ready for review October 30, 2025 14:26

angranl-flex force-pushed the angran/forceOutput branch from bf011b3 to 0a9b5ea Compare October 30, 2025 21:18

benflexcompute reviewed Oct 31, 2025

View reviewed changes

flow360/component/simulation/outputs/output_fields.py Outdated Show resolved Hide resolved

angranl-flex force-pushed the angran/forceOutput branch from 5dc97e5 to a78def5 Compare November 7, 2025 20:19

angranl-flex changed the base branch from develop to main November 10, 2025 19:11

benflexcompute reviewed Nov 12, 2025

View reviewed changes

flow360/component/simulation/outputs/outputs.py Show resolved Hide resolved

flow360/component/simulation/outputs/outputs.py Outdated Show resolved Hide resolved

flow360/component/simulation/outputs/outputs.py Outdated Show resolved Hide resolved

angranl-flex force-pushed the angran/forceOutput branch 4 times, most recently from 1c5d40e to b8854e8 Compare November 19, 2025 19:08

angranl-flex marked this pull request as draft November 19, 2025 20:10

angranl-flex marked this pull request as ready for review November 19, 2025 20:10

angranl-flex force-pushed the angran/forceOutput branch from b8854e8 to 6aec51c Compare November 23, 2025 17:57

angranl-flex force-pushed the angran/forceOutput branch 4 times, most recently from 3720942 to f7b6ddb Compare December 8, 2025 19:11

chatgpt-codex-connector bot reviewed Dec 12, 2025

View reviewed changes

benflexcompute reviewed Dec 12, 2025

View reviewed changes

angranl-flex force-pushed the angran/forceOutput branch from d07bebe to 3a88385 Compare December 15, 2025 22:07

angranl-flex added 20 commits December 15, 2025 23:06

Address comments

a3ed7b5

Enable pylint at the correct location

916c259

Remove unnecessary str input for ForceOutput and StoppingCriterion

e561338

Move parse_model_dict forward to ensure the multiconstructor models a…

5a51026

…re expanded before validation

update solver translator for more flexible dataset selection of stopp…

41f2978

…ing criterion

Address comments

eae3f33

Fix unit test after rebase

94ee7fd

Moving statistic improvement based on QA testing

2200be5

Add note for standard deviation computation

65d43f5

Add description to explain the use of tolerance window size in stoppi…

6c24254

…ng criterion check

Add stopping criterion support for imported surface integral

bbd1fa7

Adopt contextual_field validator and fix unit test

93ebb71

Address comments 1

7536309

Update movingStatistics method name from "std" and "deviation" to "st…

c063fd5

…andard_deviation" and "range"

Add helper function to handle unit conversion in translator

92f85ad

Add todo item and remove unused script

4acb874

Add deserialized the models and outputs instead of their raw dict to …

95d29e0

…the global validation context.

Remove the logic to automatically add monitor_output from stopping cr…

f8cd819

…iterion when it does not exist in outputs list

Update validation context framework for multi satge validation implem…

35b045f

…entation

Store model and output id to ForceOutput and StoppingCriterion, fix t…

e6bf758

…he related translator and validation unit test

angranl-flex force-pushed the angran/forceOutput branch from bfad398 to e6bf758 Compare December 15, 2025 23:06

benflexcompute approved these changes Dec 17, 2025

View reviewed changes

angranl-flex added 8 commits December 17, 2025 00:57

Raise ValueError when required attribute does not exist and add unit …

73e2c06

…test

Merge branch 'main' into angran/forceOutput

264c6cd

Add docstring to explain "range" method in MovingStatistics

c599831

Merge branch 'main' into angran/forceOutput

4f5aded

Fix typo

b4f11a0

Merge remote-tracking branch 'origin/main' into angran/forceOutput

e42ef0a

Merge branch 'main' into angran/forceOutput

3d0025f

Merge branch 'main' into angran/forceOutput

313d64d

	if has_instance_in_list(outputs, SurfaceIntegralOutput):
	process_user_variables_for_integral(outputs)
	integral_output = translate_monitor_output(
	outputs, SurfaceIntegralOutput, inject_surface_list_info
	)

[FXC-3564][FXC-979] ForceOutput and its stopping criterion #1519

Are you sure you want to change the base?

[FXC-3564][FXC-979] ForceOutput and its stopping criterion #1519

Uh oh!

Conversation

angranl-flex commented Oct 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benflexcompute commented Dec 11, 2025

Uh oh!

chatgpt-codex-connector bot commented Dec 11, 2025

Uh oh!

benflexcompute commented Dec 11, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

benflexcompute Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benflexcompute Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

angranl-flex Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants