Drive Android ABI list from python-build manifest's android_abis#213
Merged
Conversation
Snapshot from python-build release 20260618, which adds `android_abis` on each `pythons.<short>` entry. Replaces the hardcoded `if pythonVersion == "3.12" then 3 ABIs else 2 ABIs` branch in `serious_python_android/android/build.gradle.kts` with a read of `<short>.android_abis` from `python_versions.properties` (drives both `defaultConfig.ndk.abiFilters` and the per-ABI download/copy fan-out). - `gen_version_tables` emits `androidAbis: List<String>` on the generated `PythonRelease` class and one `<short>.android_abis=<csv>` line per minor in each native package's `python_versions.properties`. - `package_command.dart` forwards `androidAbis` from `baseRelease` to the per-run `PythonRelease` it constructs. - Pinned release bumped 20260614 -> 20260618. Adding a future minor (or flipping a 32-bit support decision) is now a one-line manifest edit in python-build — no Gradle / Dart change here. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if (pythonVersion == "3.12") listOf(3 ABIs) else listOf(2)branch inserious_python_android/android/build.gradle.ktswith a read of<short>.android_abisfrompython_versions.properties. Drives bothdefaultConfig.ndk.abiFiltersand the per-ABI download/copy fan-out.gen_version_tablesemits aList<String> androidAbisfield on the generatedPythonReleaseand one<short>.android_abis=<csv>line per minor in each native package'spython_versions.properties(Android / Darwin / Linux / Windows).package_command.dartforwardsandroidAbisfrombaseReleaseto the per-runPythonRelease.pythonReleaseDatebumped20260614→20260618(the python-build release that introducedandroid_abis, flet-dev/python-build#21).Why
3.12 carries
["arm64-v8a", "x86_64", "armeabi-v7a"]; 3.13+ are 64-bit-only (PEP 738). Encoded once in python-build'smanifest.jsonso a future minor's ABI matrix is a one-line edit there — no Gradle / Dart change here, no copy in flet's CLI.Test plan
dart run serious_python:gen_version_tablesagainst the pinned20260618release is a no-op (snapshot matches what's committed).dart analyzeclean on touched files.gen_version_tables+git diff --exit-code) passes against the live20260618release.build.gradle.ktsenumerates 3 ABIs forSERIOUS_PYTHON_VERSION=3.12and 2 for3.13/3.14.