Skip to content

Support Android TV in device info retrieval#6604

Open
bl1nch wants to merge 2 commits into
flet-dev:mainfrom
bl1nch:device-info
Open

Support Android TV in device info retrieval#6604
bl1nch wants to merge 2 commits into
flet-dev:mainfrom
bl1nch:device-info

Conversation

@bl1nch

@bl1nch bl1nch commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Description

Page.get_device_info() -> AndroidDeviceInfo if Page.platform == PagePlatform.ANDROID_TV

Test code

# Minimal test/reproduction code for reviewers, if applicable.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I signed the CLA.
  • I have performed a self-review of my own code.
  • My code follows the style guidelines of this project.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • New and existing tests pass locally with my changes.
  • I have made corresponding documentation changes, if applicable.
  • I have added changelog entries for user-facing changes, if applicable.
  • I have updated release guide pages and website/sidebars.yml for breaking changes, removals, and deprecations, if applicable.

Screenshots

Additional details

Summary by Sourcery

Bug Fixes:

  • Ensure Android TV pages return AndroidDeviceInfo when calling get_device_info instead of being unsupported or misclassified.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@ndonkoHenri

Copy link
Copy Markdown
Contributor

Thanks for the addition. Did you please test it works properly there? For example, by calling that invoke-method from your app (running on the android tv), to see if it returns properly/correctly.

@FeodorFitsner

Copy link
Copy Markdown
Contributor

...also, instead of or shouldn't it be like self.platform in [...]?

@bl1nch

bl1nch commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the addition. Did you please test it works properly there? For example, by calling that invoke-method from your app (running on the android tv), to see if it returns properly/correctly.

Yes, I've tested it on the Android TV devices I have on hand (which report page.platform as PagePlatform.ANDROID_TV). Calling get_device_info() works properly and returns the correct device info without any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants