fix: improving handling of unbounded width in ResponsiveRow#6354
Open
ndonkoHenri wants to merge 5 commits intomainfrom
Open
fix: improving handling of unbounded width in ResponsiveRow#6354ndonkoHenri wants to merge 5 commits intomainfrom
ResponsiveRow#6354ndonkoHenri wants to merge 5 commits intomainfrom
Conversation
Deploying flet-docs with
|
| Latest commit: |
fa5cf52
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f4a9bd0a.flet-docs.pages.dev |
| Branch Preview URL: | https://fix-responsive-row-width.flet-docs.pages.dev |
Contributor
There was a problem hiding this comment.
Pull request overview
Improves handling of layout constraint edge-cases (notably unbounded constraints) by surfacing clear runtime errors in the Flutter client and adding golden/integration coverage for these scenarios.
Changes:
- Add an explicit unbounded-width guard to
ResponsiveRow(Flutter) that renders anErrorControlwith guidance. - Add/extend integration + golden tests for unbounded constraint cases (ResponsiveRow width; PageView/Pagelet/NavigationRail/TabBarView height).
- Adjust Python
NavigationRailDestination.icontyping/requiredness and bumpclient/pubspec.lockto matchpackages/fletversion.
Reviewed changes
Copilot reviewed 7 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
packages/flet/lib/src/controls/responsive_row.dart |
Detects unbounded width and renders a helpful ErrorControl instead of mis-layout. |
sdk/python/packages/flet/integration_tests/controls/core/test_responsive_row.py |
Adds screenshot test coverage for unbounded-width ResponsiveRow. |
sdk/python/packages/flet/integration_tests/controls/core/test_page_view.py |
Adds screenshot test for unbounded-height PageView. |
sdk/python/packages/flet/integration_tests/controls/core/test_pagelet.py |
Adds screenshot test for unbounded-height Pagelet. |
sdk/python/packages/flet/integration_tests/controls/material/test_navigation_rail.py |
Adds screenshot test for unbounded-height NavigationRail. |
sdk/python/packages/flet/integration_tests/controls/material/test_tabs.py |
Adds screenshot test for unbounded-height TabBarView. |
sdk/python/packages/flet/src/flet/controls/material/navigation_rail.py |
Changes NavigationRailDestination.icon to be required in the Python API. |
sdk/python/packages/flet/integration_tests/**/golden/**.png |
New golden images for the added constraint-error scenarios. |
client/pubspec.lock |
Updates locked versions (including flet 0.83.1) consistent with the repo package version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sdk/python/packages/flet/src/flet/controls/material/navigation_rail.py
Outdated
Show resolved
Hide resolved
Deploying flet-examples with
|
| Latest commit: |
fa5cf52
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9c110ded.flet-examples.pages.dev |
| Branch Preview URL: | https://fix-responsive-row-width.flet-examples.pages.dev |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1951
Test code
Summary by Sourcery
Handle unbounded layout constraints more robustly and improve visual regression coverage for affected controls.
New Features:
Bug Fixes:
Enhancements:
Tests: