Fix TestUpgradeCodesFromMaintainedApps after Cloudflare WARP rename#47953
Conversation
The Cloudflare WARP FMA display name was renamed to 'Cloudflare One' in #47939, but TestUpgradeCodesFromMaintainedApps still looked up the FMA by name = 'Cloudflare WARP', so it failed with 'sql: no rows in result set'. Update both lookups to 'Cloudflare One' (the windows unique_identifier, 'Cloudflare One Client', is unchanged).
|
@jkatz01 thanks! I was just putting in a PR for this. Sorry for breaking it! |
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughTwo SQL queries inside Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.43.0)server/service/integration_enterprise_test.goThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@allenhouchins no problem, pretty random thing for a test to use 😅 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #47953 +/- ##
==========================================
- Coverage 67.31% 67.31% -0.01%
==========================================
Files 3655 3655
Lines 231251 231251
Branches 12075 12075
==========================================
- Hits 155667 155665 -2
- Misses 61620 61621 +1
- Partials 13964 13965 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Related issue: Resolves #
Cloudflare WARP was renamed to Cloudflare One, and this test used it's name in the fleet_maintained_apps table
Checklist for submitter
If some of the following don't apply, delete the relevant line.
Changes file added for user-visible changes in
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
Input data is properly validated,
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters.Timeouts are implemented and retries are limited to avoid infinite loops
If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes
Testing
Added/updated automated tests
Where appropriate, automated tests simulate multiple hosts and test for host isolation (updates to one hosts's records do not affect another)
QA'd all new/changed functionality manually
N/A but needed for CI check
Summary by CodeRabbit