Skip to content

Android $FLEET_VAR_HOST usage#47871

Open
ksykulev wants to merge 1 commit into
docs-v4.89.0from
android-fleet-vars-host
Open

Android $FLEET_VAR_HOST usage#47871
ksykulev wants to merge 1 commit into
docs-v4.89.0from
android-fleet-vars-host

Conversation

@ksykulev

@ksykulev ksykulev commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Related issue: Resolves #45353, #41968

Copilot AI review requested due to automatic review settings June 18, 2026 20:15

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@ksykulev ksykulev changed the base branch from main to docs-v4.89.0 June 18, 2026 20:18
@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c0246888-57bf-431e-bb1e-ee31793fdd8e

📥 Commits

Reviewing files that changed from the base of the PR and between 65eda11 and a64b305.

⛔ Files ignored due to path filters (1)
  • articles/fleet-variables.md is excluded by !**/*.md
📒 Files selected for processing (2)
  • schema/osquery_fleet_schema.json
  • schema/tables/ai_tools.yml

Walkthrough

This pull request introduces a new osquery table schema named ai_tools across two files. The YAML source (schema/tables/ai_tools.yml) defines the table metadata, platform support, evented flag, example SQL queries, notes, and the full column set. The compiled JSON representation (schema/osquery_fleet_schema.json) mirrors this definition with the addition of url and fleetRepoUrl fields. The table covers AI-related artifacts on hosts including MCP servers, AI agent CLIs, desktop apps, IDE plugins, socket endpoints, and agent instruction files, with columns for identification, provenance, runtime status, security risk indicators, artifact fingerprinting, and ownership.

🚥 Pre-merge checks | ✅ 1 | ❌ 4

❌ Failed checks (3 warnings, 1 inconclusive)

Check name Status Explanation Resolution
Title check ⚠️ Warning Title describes Android host variable support but changeset only adds ai_tools schema with no Android-related code. Update title to accurately reflect the ai_tools schema addition, e.g., 'Add ai_tools osquery table schema definition' or clarify the actual changes being made.
Linked Issues check ⚠️ Warning Linked issues require Android $FLEET_VAR_HOST_ variable substitution implementation, but changeset only adds ai_tools osquery schema with no Android variable substitution code. Ensure the PR implements Android variable substitution logic for $FLEET_VAR_HOST_ variables as specified in issues #45353 and #41968, not just schema definitions.
Out of Scope Changes check ⚠️ Warning The ai_tools osquery schema additions appear unrelated to the Android variable substitution feature described in the PR objectives and linked issues. Remove out-of-scope schema changes or clarify their connection to Android variable substitution requirements. Refocus on the stated PR objectives.
Description check ❓ Inconclusive Description references resolved issues #45353 and #41968 but provides no other details about the changes or testing performed. Expand description to explain what changes were made, which files were modified, and how the linked issues were addressed in this PR.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch android-fleet-vars-host

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Not ready to approve

The PR’s stated scope (Android $FLEET_VAR_HOST_… usage) does not match the visible schema changes, and there are minor schema doc consistency/formatting issues to address.

Warning

  • Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.
Pull request overview

This PR adds a new ai_tools entry to Fleet’s osquery schema documentation (YAML + the generated canonical JSON schema), intended to document an osquery table that surfaces AI tooling artifacts on hosts.

Changes:

  • Added a new schema table definition at schema/tables/ai_tools.yml.
  • Updated schema/osquery_fleet_schema.json to include the new ai_tools table entry.
  • Updated articles/fleet-variables.md (content excluded from this review by policy).
File summaries
File Description
schema/tables/ai_tools.yml Introduces the YAML schema documentation for the new ai_tools table, including columns/examples/notes.
schema/osquery_fleet_schema.json Adds the canonical JSON schema entry for ai_tools (used by fleetdm.com/tables and related tooling).
articles/fleet-variables.md Updated, but excluded by org policy so contents could not be reviewed here.

Copilot's findings

Copilot wasn't able to review any files in this pull request.

Files excluded by content exclusion policy (1)

  • articles/fleet-variables.md
  • Files reviewed: 0/1 changed files
  • Comments generated: 0

Note

Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android managed app configuration: support all FLEET_VAR_HOST_ variables

4 participants