Skip to content

Use display name when applicable for Android config change updates#42626

Open
iansltx wants to merge 2 commits intomainfrom
42383-android-display-name
Open

Use display name when applicable for Android config change updates#42626
iansltx wants to merge 2 commits intomainfrom
42383-android-display-name

Conversation

@iansltx
Copy link
Copy Markdown
Member

@iansltx iansltx commented Mar 28, 2026

Resolves #42383. Re-roll of #42384 using the relevant helper function.

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

Testing

  • QA'd all new/changed functionality manually

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Enhanced Android software configuration success notifications to dynamically display the actual software display name, replacing previously static messaging. This improvement provides users with more specific and personalized feedback when confirming successful software configurations, improving clarity and reducing potential confusion when managing multiple software installations or updates on their Android devices.

Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.66%. Comparing base (9bfef5d) to head (a98dcf2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #42626   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files        2535     2535           
  Lines      203320   203320           
  Branches     9114     9114           
=======================================
  Hits       135551   135551           
  Misses      55500    55500           
  Partials    12269    12269           
Flag Coverage Δ
frontend 54.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iansltx
Copy link
Copy Markdown
Member Author

iansltx commented Mar 28, 2026

@coderabbitai full-review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 28, 2026

@iansltx Sure! I'll redo the full review of the PR now.

✅ Actions performed

Full review triggered.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c177319f-29ba-4347-8b2d-82a882689af2

📥 Commits

Reviewing files that changed from the base of the PR and between fb975a7 and a98dcf2.

📒 Files selected for processing (2)
  • changes/42383-android-display-name
  • frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditConfigurationModal/EditConfigurationModal.tsx

Walkthrough

A success flash message template in the Android software configuration flow was updated to display the computed software display name instead of static wording. The change introduces the use of a getDisplayedSoftwareName function that evaluates both the software name and display name fields to determine the appropriate value to show in the success notification when configuration changes are saved.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately summarizes the main change: using the display name for Android config change update messages.
Description check ✅ Passed The description includes the resolved issue reference and confirms a changes file was added, though manual QA checkbox remains unchecked.
Linked Issues check ✅ Passed The PR successfully addresses issue #42383 by updating the Android config success message to use display_name instead of name.
Out of Scope Changes check ✅ Passed All changes are directly related to resolving issue #42383; the helper function import and message template updates are scope-appropriate.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 42383-android-display-name

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android software: show display name in success message when configuration is edited

2 participants