Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sgress454
requested review from
georgekarrv,
getvictor,
lucasmrod,
lukeheath and
sharon-fdm
as code owners
|
Oh boy. Now I think I need approval from both @allenhouchins and one of the GitHub workflows owners. |
| - "tools/fleetctl-docker/**" | ||
| - "tools/wix-docker/**" | ||
| - "tools/bomutils-docker/**" | ||
| - ".github/workflows/test-packaging.yml" |
There was a problem hiding this comment.
Missed that this happened, it's just our prettier rule demanding double-quotes. Might as well keep it or it'll just happen next time someone else edits this file.
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-latest, macos-15] | ||
| os: [ubuntu-latest, macos-15, macos-26] |
There was a problem hiding this comment.
Adding macos-26 to the matrix to test packaging on Tahoe.
| brew install --cask --no-quarantine fleet/local/wine-stable; exit 0 | ||
| brew install --cask fleet/local/wine-stable | ||
| xattr -dr com.apple.quarantine "$(brew --prefix)/Caskroom/wine-stable" | ||
| exit 0 |
There was a problem hiding this comment.
since --no-quarantine is no longer an option on brew install, we do it manually.
Rename/move macOS install-wine.sh from it-and-security/lib/macos/scripts to assets/scripts and update all references: adjust the GitHub Actions workflow to call the new script path and update the website route to point to the new repository location so links and CI use the relocated script.
allenhouchins
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
|
@sgress454 the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #42570 +/- ##
========================================
Coverage 66.64% 66.65%
========================================
Files 2532 2533 +1
Lines 202930 203043 +113
Branches 9180 9231 +51
========================================
+ Hits 135243 135332 +89
- Misses 55439 55460 +21
- Partials 12248 12251 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
test passed with the new path, works for me 👍 |
Related issue: Resolves #42573
Fixes failing test by replacing no-longer-supported
--no-quarantineoption with manually turning off quarantine for Wine.Successful run here: https://github.com/fleetdm/fleet/actions/runs/23661332211