Move NewActivity to activity bounded context#39521
Merged
Conversation
…actor activity streaming to use ListActivities service with system-based authorization. Improve test coverage for cron activities.
Resolve merge conflicts: - Keep branch's StreamActivities approach instead of main's cronActivitiesStreaming - Keep branch's HostProvider and GetHostLite additions to activity service - Remove main's MarkActivitiesAsStreamed from fleet.Datastore (now handled by activity service) - Remove main's testListHostPastActivities and cronActivitiesStreaming tests (not applicable to branch approach)
getvictor
changed the title
cdcme
previously approved these changes
Feb 24, 2026
lucasmrod
previously approved these changes
Feb 25, 2026
| } | ||
| } | ||
|
|
||
| func testListActivitiesHostOnlyExcluded(t *testing.T, env *testEnv) { |
Member
There was a problem hiding this comment.
Was this test moved elsewhere?
Member
Author
There was a problem hiding this comment.
It is now covered by testNewActivityHostOnly at line 200 of the new file server/activity/internal/mysql/new_activity_test.go
JordanMontgomery
previously approved these changes
Feb 25, 2026
# Conflicts: # server/datastore/mysql/activities.go # server/datastore/mysql/mysql.go # server/mdm/lifecycle/lifecycle.go # server/mdm/lifecycle/lifecycle_test.go # server/service/activities.go # server/service/modules/activities/activities.go
getvictor
dismissed stale reviews from JordanMontgomery, lucasmrod, and cdcme
via
33da217
lucasmrod
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Resolves #38536
This PR moves all logic to create new activities to activity bounded context.
The old service and ActivityModule methods are not facades that route to the new activity bounded context. The facades will be removed in a subsequent PR.
Checklist for submitter
changes/,orbit/changes/oree/fleetd-chrome/changes.Testing
Summary by CodeRabbit
New Features
Improvements