Skip to content

add additional logging for SCEP proxy and SCEP profiles#39501

Open
MagnusHJensen wants to merge 2 commits intomainfrom
36361-more-debug-logging-for-ca-profiles
Open

add additional logging for SCEP proxy and SCEP profiles#39501
MagnusHJensen wants to merge 2 commits intomainfrom
36361-more-debug-logging-for-ca-profiles

Conversation

@MagnusHJensen
Copy link
Member

Related issue: Resolves #36361

This PR adds some additional debug logging to log hostUUID:profileUUID when renewing MDM managed certificates.
Also adds log statements when processing a profile, when hitting NDES or Smallstep (not SCEP as it's a static challenge, that is fetched and replaced, no external calls).

NDES: If we get a successful call (which is the standard, with errors on the HTML page), we debug log, the entire HTML response, and the request duration.
Smallstep: Normal API errors, non OK we log: status code, the status text, the request duration, and spit out the entire body (max 2mb), if more than 2mb we don't log the response body.

I tried looking for more relevant places, but couldn't really find any that would make sense to log for this ticket.

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

Testing

  • Added/updated automated tests
  • QA'd all new/changed functionality manually -> Did a quick test for some of the logs, but the NDES one is not really easy to verify.

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.22%. Comparing base (15d123d) to head (f981476).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
ee/server/service/scep_proxy.go 50.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #39501      +/-   ##
==========================================
+ Coverage   64.37%   66.22%   +1.85%     
==========================================
  Files        2398     2430      +32     
  Lines      187450   194703    +7253     
  Branches     8544     8544              
==========================================
+ Hits       120673   128948    +8275     
+ Misses      55866    54054    -1812     
- Partials    10911    11701     +790     
Flag Coverage Δ
backend 68.00% <66.66%> (+2.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Insufficient logging for SCEP/NDES enrollment failures

1 participant