add additional logging for SCEP proxy and SCEP profiles#39501
Open
MagnusHJensen wants to merge 2 commits intomainfrom
Open
add additional logging for SCEP proxy and SCEP profiles#39501MagnusHJensen wants to merge 2 commits intomainfrom
MagnusHJensen wants to merge 2 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #39501 +/- ##
==========================================
+ Coverage 64.37% 66.22% +1.85%
==========================================
Files 2398 2430 +32
Lines 187450 194703 +7253
Branches 8544 8544
==========================================
+ Hits 120673 128948 +8275
+ Misses 55866 54054 -1812
- Partials 10911 11701 +790
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Resolves #36361
This PR adds some additional debug logging to log hostUUID:profileUUID when renewing MDM managed certificates.
Also adds log statements when processing a profile, when hitting NDES or Smallstep (not SCEP as it's a static challenge, that is fetched and replaced, no external calls).
NDES: If we get a successful call (which is the standard, with errors on the HTML page), we debug log, the entire HTML response, and the request duration.
Smallstep: Normal API errors, non OK we log: status code, the status text, the request duration, and spit out the entire body (max 2mb), if more than 2mb we don't log the response body.
I tried looking for more relevant places, but couldn't really find any that would make sense to log for this ticket.
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
Testing