Strip suffixes from non-snapshot builds when determining which npm package to download #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitOps side of #39522. OpenCode + Kimi K2.5; prompt: In .github/gitops-action/action.yml, strip anything after `-` or `+` when determining the FLEET_VERSION variable, such that 4.81.0-rc.1234567 or 4.81.0+foobar raw versions both resolve to 4.81.0.
OpenCode + Kimi K2.5; prompt: In .github/gitops-action/action.yml, pass FLEET_VERSION verbatim rather than stripping ending characters when it starts with 0.0.0-SNAPSHOT
RCs won't have a fleetctl published yet, so we should fall back to the default.
There was a problem hiding this comment.
Pull request overview
Updates the composite GitHub Action that installs fleetctl so it can resolve the correct npm package version when the Fleet server reports a non-snapshot version with build metadata suffixes (e.g. branch builds).
Changes:
- Treat
0.0.0-SNAPSHOT*server versions explicitly as “use the default pinnedfleetctlversion”. - Strip SemVer build metadata (
+...) from non-snapshot versions before validating and selecting the npmfleetctl@<version>to install.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
We don't release the RC version of fleetctl to npm right now. Do we need to start doing that for this to work? |
Member
Author
|
We don't. I backed out the RC specific stuff so this just covers cases where we are (will be) appending build info to the end of a GA version (for branch builds). |
getvictor
approved these changes
Feb 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for grabbing a matching
fleetctlfor branch based builds following the convention in fleetdm/fleet#39522.