New best practice teams #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Hey @getvictor can you please review/merge this PR when you get the chance? |
getvictor
reviewed
Feb 2, 2026
Member
getvictor
left a comment
getvictor
left a comment
There was a problem hiding this comment.
The CI check is failing. It runs against a test Fleet server on Render. Please make sure it is passing with these changes.
Please add the new secrets to the secrets in this repo:
teams/workstations.yml
Outdated
Comment on lines
3
to
5
| - path: ../lib/macos.policies.yml | ||
| - path: ../lib/windows.policies.yml | ||
| - path: ../lib/linux.policies.yml |
Member
There was a problem hiding this comment.
I don't see where these new files are at.
teams/workstations.yml
Outdated
| scripts: | ||
| - path: ../lib/macos/scripts/remove-zoom-artifacts.script.sh | ||
| - path: ../lib/macos/scripts/set-timezone.script.sh | ||
| - path: ../lib/collect-fleetd-logs.sh |
Member
There was a problem hiding this comment.
I don't see where this new file is at.
noahtalerman
commented
Feb 2, 2026
noahtalerman
commented
Feb 2, 2026
noahtalerman
commented
Feb 2, 2026
noahtalerman
commented
Feb 2, 2026
noahtalerman
commented
Feb 2, 2026
noahtalerman
commented
Feb 2, 2026
noahtalerman
commented
Feb 3, 2026
noahtalerman
commented
Feb 3, 2026
noahtalerman
commented
Feb 3, 2026
noahtalerman
commented
Feb 3, 2026
noahtalerman
commented
Feb 3, 2026
noahtalerman
commented
Feb 3, 2026
noahtalerman
commented
Feb 3, 2026
noahtalerman
commented
Feb 3, 2026
getvictor
approved these changes
Feb 3, 2026
sgress454
added a commit
to fleetdm/fleet
that referenced
this pull request
Feb 3, 2026
Due to [recent changes to the fleet-gitops repo](fleetdm/fleet-gitops#91), some tests need to be updated to match the expected # of teams.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.