fix: Use Fleet SDK Task.verify_detailed() for verifier execution#4
Closed
dzorlu wants to merge 1 commit intodeniz/fleet_clientfrom
Closed
fix: Use Fleet SDK Task.verify_detailed() for verifier execution#4dzorlu wants to merge 1 commit intodeniz/fleet_clientfrom
dzorlu wants to merge 1 commit intodeniz/fleet_clientfrom
Conversation
Replace custom _execute_verifier_local() with Fleet SDK's Task.verify_detailed() which properly sets up the verifier namespace with: - Environment type annotation - Helper functions (normalized_contains, etc.) - Proper function discovery (not just "verify" function) This fixes "name 'Environment' is not defined" errors during verifier execution. Changes: - _compute_reward: Create Fleet SDK Task and call verify_detailed() - Support both 'verifier_code' and 'verifier_func' field names - Add comprehensive logging for debugging - Remove broken _execute_verifier_local method Tests: - Update all verifier tests to mock Fleet SDK Task.verify_detailed() - Add tests for various edge cases (no verifier, no orch, exceptions) - Fix fixture to avoid asyncio.run() conflicts with pytest-asyncio 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
Author
|
Merging into PR #1 instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_execute_verifier_local()with Fleet SDK'sTask.verify_detailed()Environmenttype and helper functionsProblem
The previous implementation used a bare
exec()with an empty namespace, which caused verifiers usingEnvironmenttype annotations to fail with:Fleet SDK's
verifier_from_string()properly injectsEnvironment: objectand other helpers into the namespace.Changes
_compute_reward: Create Fleet SDKTaskobject and callverify_detailed(fleet_env)verifier_code(OpenEnv) andverifier_func(Fleet SDK) field names_execute_verifier_localmethodTest plan
verifier_funcfield name🤖 Generated with Claude Code