Ensure value is string before validating format#117
Open
melvey wants to merge 1 commit intoflatiron:masterfrom
Open
Ensure value is string before validating format#117melvey wants to merge 1 commit intoflatiron:masterfrom
melvey wants to merge 1 commit intoflatiron:masterfrom
Conversation
Author
|
Looks like the travis build fails to install dependencies as npm uses arrow functions which are not supported in the target node versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Format validation can only be applied to string objects. Checking the value is a string before validating the format means that format validation can be used when multiple types are accepted
e.g.