Update winston to 3.x

[Terseus]

This change is needed for foreversd/forever#1077.

Note that winston 3 requires Node.js >= 6.4.0 so this change breaks compatibility with older Node.js versions.

[Terseus]

@zoobot I cannot reproduce the issue anymore in this branch.

Anyway I've added a test to prevent other warnings in the future.

You can test the behavior with this script:

var cliff = require('./lib/cliff.js');

process.on('warning', function() {
  console.error("Oops, warning detected!");
});

var rows = [
    ['a', 'b'],
];


cliff.putRows('info', rows, ['red', 'blue']);

When I run it on master branch:

$ node --version
v15.12.0
$ node ./warning-test.js
info:    a b
(node:39912) Warning: Accessing non-existent property 'padLevels' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)
Oops, warning detected!

When I run it on this branch (be sure to delete node_modules and execute npm install to update winston):

$ node --version
v15.12.0
$ node ./warning-test.js
info:    a b

If you're still having the issue, please provide an small example so I'm able to test it.

[meissnere]

wonderful. let's pull this into flatiron master to fix these winston issues

[meissnere]

wonderful. let's pull this into flatiron master to fix these winston issues

[MatrixFrog]

Suggested change

	cliff.logger = new winston.createLogger({
	cliff.logger = winston.createLogger({

[Terseus]

Oops you're right, I'll add it in a87d5da, thanks!