Open
Conversation
bbhtt
reviewed
Apr 10, 2026
Contributor
|
can you link to the pango change and why this is needed? is the build failing without this? what's the error? |
Author
|
Thank you for taking the time. I should have explained and do a better research. Actually, the error is not due to a change in pango but the upgrade from gcc 13 to gcc 14. I checked previous gnome runtime versions and the error already started occuring in version 47. With that change the warnings turned into errors by default. So we can get away with just setting the errors back to warnings. This is the failing build log for pygtk used by gwyddion. |
bbhtt
reviewed
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes pango apis which are not there for gnome 50. It is conditional, so that apis remain untouched for older runtimes.
I'm not sure if such behavior is desired.