fix(syncer-updates): separate target from floors in update logic#1291
Open
ervcz wants to merge 2 commits intofeat/capture-oem-attributefrom
Open
fix(syncer-updates): separate target from floors in update logic#1291ervcz wants to merge 2 commits intofeat/capture-oem-attributefrom
ervcz wants to merge 2 commits intofeat/capture-oem-attributefrom
Conversation
- Add OEM and OEM version columns to instance table - Update RegisterInstance and GetUpdatePackage calls to include OEM parameters - Modify test cases to pass empty OEM values for compatibility Signed-off-by: Ervin Rácz <ervin.racz@protonmail.com>
Bug: Syncer received batches with the target even if there were still floor packages waiting to be sent. The target would have been used by the next syncer omaha request and that prevented preparing the remaining floors to be sent. - Update GetUpdatePackagesForSyncer to handle floors and target separately - Fix tests for multi-step-updates floor pagination for syncers - Modify update selection to prioritize floors before target package - Add LIMIT+1 query pattern for floor pagination detection - Update architecture decisions doc Signed-off-by: Ervin Rácz <ervin.racz@protonmail.com>
ervcz
force-pushed
the
fix/floors-in-multiple-batch
branch
from
4fc1de7 to
ca2d4b8
Compare
ervcz
force-pushed
the
feat/capture-oem-attribute
branch
3 times, most recently
from
17439e7 to
efd1f3d
Compare
ervcz
force-pushed
the
feat/capture-oem-attribute
branch
from
2d52519 to
410381d
Compare
ervcz
force-pushed
the
feat/capture-oem-attribute
branch
from
410381d to
0ef741f
Compare
ervcz
force-pushed
the
feat/capture-oem-attribute
branch
from
0ef741f to
db18dd5
Compare
ervcz
force-pushed
the
feat/capture-oem-attribute
branch
2 times, most recently
from
a0b40ea to
a345261
Compare
ervcz
force-pushed
the
feat/capture-oem-attribute
branch
from
7c54b45 to
cbf596a
Compare
ervcz
force-pushed
the
feat/capture-oem-attribute
branch
4 times, most recently
from
71a3566 to
a2e56c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When more floor packages exist than
NEBRASKA_MAX_FLOORS_PER_RESPONSE, the server incorrectly included the target in every batch. This caused syncers to skip remaining floors.Solution
Changes
GetUpdatePackagesForSyncerreturns(floors, target, error)separatelyGetRequiredChannelFloorsWithLimituses LIMIT+1 to detect remaining floorsTestFloorLimitPaginationandTestSyncer_FloorLimitVersionTracking