Capture OEM and OEM Version attributes from Omaha requests

[ervcz]

Summary

Captures OEM and Aleph version attributes from Omaha update requests, and refactors registration APIs to use struct params.

Changes

Database

• New migration 0021_add_instance_oem.sql adds oem and aleph_version columns to the instance table

API

• RegisterInstance, GetUpdatePackage, and GetUpdatePackagesForSyncer refactored from positional string params to Instance/InstanceApplication structs
• NewInstanceApplication helper added for constructing registration input

Tests

• Added test coverage for OEM/AlephVersion save, preserve, and update scenarios
• Updated all existing test call sites for the new struct-based API

[jepio]

Just a note: OEM version is not particularly interesting as it is tightly coupled to the OS version and always updated in lockstep - one may look it up in the source repo git tag.

The alephversion attribute from the request would be more interesting - it tells you the initial version an instance was provisioned from.

[ervcz]

Just a note: OEM version is not particularly interesting as it is tightly coupled to the OS version and always updated in lockstep - one may look it up in the source repo git tag.

The alephversion attribute from the request would be more interesting - it tells you the initial version an instance was provisioned from.

Thanks for the note. I'll replace it with alephversion as suggested. That brings more value. We will know the "age" of individual nodes.

[Copilot]

Pull request overview

Captures OEM and Aleph version attributes from Omaha update requests and refactors instance registration/update lookup APIs to use struct-based parameters.

Changes:

• Add oem and aleph_version columns to the instance table.
• Refactor RegisterInstance, GetUpdatePackage, and GetUpdatePackagesForSyncer to accept Instance / InstanceApplication structs (plus NewInstanceApplication helper).
• Update and extend tests to cover OEM/AlephVersion persistence and to use the new APIs.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
backend/pkg/api/db/migrations/0021_add_instance_oem.sql	Adds DB columns to persist OEM/AlephVersion.
backend/pkg/api/instances.go	Extends Instance model and updates registration to upsert OEM/AlephVersion.
backend/pkg/omaha/omaha.go	Populates OEM/AlephVersion from Omaha requests into instance registration calls.
backend/pkg/api/updates.go	Refactors update lookup APIs to use struct params and relies on struct-based registration.
backend/pkg/api/instances_test.go	Adds coverage for saving/preserving/updating OEM/AlephVersion and updates call sites.
backend/pkg/api/updates_test.go	Updates test call sites to the new struct-based API.
backend/pkg/api/packages_floors_test.go	Updates floor-related tests for the new GetUpdatePackage signature.
backend/pkg/api/events_test.go	Updates event tests to use struct-based GetUpdatePackage/RegisterInstance.
backend/pkg/api/groups_test.go	Updates group tests to use struct-based instance registration.
backend/pkg/api/applications_test.go	Updates application tests to use struct-based instance registration.
backend/pkg/api/activity_test.go	Updates activity tests to use struct-based instance registration.
backend/test/api/instance_test.go	Updates higher-level API tests to use struct-based registration/update calls.
backend/test/api/stats_test.go	Updates stats tests to use struct-based registration/update calls.
CHANGELOG.md	Documents OEM/AlephVersion capture behavior.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[John15321]

LGTM! Thank you!