Rollup boost shadow builder #461
Open
+354
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
avalonche
force-pushed
the
rollup-boost-shadow-builder
branch
from
6af04bd to
e32587d
Compare
SozinM
reviewed
Dec 19, 2025
crates/rollup-boost/src/proxy.rs
Outdated
| }); | ||
| } | ||
|
|
||
| // If the shadow builder is enabled, forward the request to the shadow builder |
Collaborator
There was a problem hiding this comment.
this won't mirror engine_calls, because we do return there
Collaborator
|
Moved one part, for the other will add shadow builder client into FlashblocksService and will make proxying there, after sending call to the builder |
Member
|
should we add to the docs? |
Contributor
|
Has the alternative of having multiple remote builders been properly explored? The issue says
but why can't we control if something is a fallback or silent observer with flags/configuration? |
Collaborator
|
After discussing this with @akundaz we decided that it would be good to add
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #460