refactor: start cleaning up execution info#526
Open
akundaz wants to merge 4 commits into
Open
Conversation
julio4
reviewed
May 22, 2026
Member
There was a problem hiding this comment.
I don't think ExecutionInfo is the right place to keep track of flashblocks index. I would prefer if possible splitting in object of same lifecycle: one for the slot/payload, one per flashblock.
budget check functions are nice but we could do even more, what do you have in mind for "Budgeting refactor still in progress"?
Rest looks good!
|
|
||
| use super::{ExecutionInfo, TxnExecutionResult}; | ||
|
|
||
| fn execution_info_with_uncompressed_bytes(cumulative_uncompressed_bytes: u64) -> ExecutionInfo { |
Member
There was a problem hiding this comment.
nit: you can also add a implementation on ExecutionInfo under test cfg to do ExecutionInfo::with_uncompressed_bytes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a few small refactors in this PR:
Budgeting refactor still in progress