Prevent host PATH from leaking into nix build env#155
Open
alexhulbert wants to merge 3 commits into
Open
Conversation
Member
Author
|
The listed packages in the changed flake.nix file are the only ones referenced by mkosi itself (or ones that make more sense to run outside of chroot) |
Member
Author
|
@0x416e746f6e Made an update to this branch and did a thorough test on several environments. It effectively removes the /usr/bin and /usr/sbin prepended to the PATH for all mkosi files while preserving those PATHs in mkosi-chroot. |
Member
|
thanks. the update had fixed the build |
0x416e746f6e
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure that only nix-provided binaries are in the PATH when mkosi runs. It fixes the issue referenced in #152 and any future issues of the same class.
Tested both inside and outside Lima and it produces the same hashes on both.