fix: remove 10m operation timeout regression (v0.2.0)#31
Merged
flashadmin merged 1 commit intomainfrom Apr 21, 2026
Merged
Conversation
…2.0) v0.2.0 activated a hardcoded 10-minute client-side deadline in WaitForSQLOperation via context.WithTimeout. The `timeout` parameter existed in v0.1.x but was dead code; wrapping the context with it turned operation polling into a ticking bomb for any export that exceeds 10m. Large CloudSQL exports routinely run hours. Remove the in-app deadline and bound polling only by the parent context, so callers can still impose their own deadline (and SIGTERM still propagates).
flashadmin
deleted the
cloudsql-exporter-remove-operation-timeout-2026042101
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WaitForSQLOperationby wrapping the parent context withcontext.WithTimeout. The sametimeoutparameter existed in v0.1.x but was dead code — so polling effectively ran as long as needed. v0.2.0 flipped it into an enforced deadline.timeout waiting for operation ... context deadline exceededfailures.timeoutparameter, and leaves polling bounded by the parent context (so callers can still impose a deadline viactx, and SIGTERM still propagates).Test plan
go build ./...passesgo vet ./...passes