[fix] Add copy of label to prevent errors#745
Merged
Conversation
ldmonster
reviewed
Mar 30, 2026
ldmonster
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix map reference sharing in MemoryMetricsCollector Set and Add methods by copying labels before storing.
What this PR does / why we need it
MetricsCollector.SetandMetricsCollector.Addstored a direct reference to the labels map passed by the caller. When a hook iterates over multiple objects and reuses the same map (mutating it each iteration), all previously appended MetricOperation entries end up pointing to the same underlying map. As a result, only the last set of labels survives - earlier time series are effectively overwritten.This PR introduces a copyLabels helper that copies the map before storing it in MetricOperation, ensuring each metric has its own independent label set.
Example of affected hook pattern:
After this fix, N violations produce N independent time series in Prometheus as expected.