Skip to content

fix(plugin): return error on invalid plugin selector#3135

Merged
adityathebe merged 4 commits into
mainfrom
fix/peg-errors
May 22, 2026
Merged

fix(plugin): return error on invalid plugin selector#3135
adityathebe merged 4 commits into
mainfrom
fix/peg-errors

Conversation

@adityathebe
Copy link
Copy Markdown
Member

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 22, 2026

Warning

Rate limit exceeded

@adityathebe has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 8 minutes and 52 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5df3fba7-46e1-479d-887c-bb34c6d9cfbd

📥 Commits

Reviewing files that changed from the base of the PR and between 93a892f and aea3652.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (8)
  • db/playbooks.go
  • db/views.go
  • go.mod
  • notification/events.go
  • plugin/controller/controller.go
  • plugin/controller/proxy.go
  • plugin/runtime/invoke.go
  • views/scopes.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/peg-errors
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/peg-errors

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 22, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedgolang/​github.com/​flanksource/​duty@​v1.0.1310 ⏵ v1.0.131275 +1100100100100

View full report

Invalid silence filters or selectors can be evaluated for every notification and spam logs/errors repeatedly. Skip failed silence matches quietly so notification processing continues without noisy side effects.
@adityathebe adityathebe enabled auto-merge (squash) May 22, 2026 10:06
@adityathebe adityathebe disabled auto-merge May 22, 2026 10:06
@adityathebe adityathebe enabled auto-merge (squash) May 22, 2026 10:09
Selector matching errors can happen while evaluating silences for every notification. Avoid logging or updating silence errors from getFirstSilencer for these per-notification match failures; skip the invalid selector and continue.
@adityathebe adityathebe merged commit a99f388 into main May 22, 2026
10 checks passed
@adityathebe adityathebe deleted the fix/peg-errors branch May 22, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant