Skip to content

chore(ui/playbook): remove params and move recent targets inside modal#3127

Open
yashmehrotra wants to merge 2 commits into
mainfrom
ui-pb
Open

chore(ui/playbook): remove params and move recent targets inside modal#3127
yashmehrotra wants to merge 2 commits into
mainfrom
ui-pb

Conversation

@yashmehrotra
Copy link
Copy Markdown
Member

@yashmehrotra yashmehrotra commented May 20, 2026

Summary by CodeRabbit

  • New Features

    • Added "Suggested targets" UI for playbook runs to streamline target selection based on recent usage.
  • Style

    • Removed parameter-count badges from library cards and playbook run dialogs for a cleaner interface.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 990c2dad-2742-4a2a-b090-ce886467ab16

📥 Commits

Reviewing files that changed from the base of the PR and between aa73d09 and e7948f7.

📒 Files selected for processing (1)
  • ui/frontend/src/playbooks/PlaybookBrowser.tsx

Walkthrough

The PR extends playbook run flows to track and suggest recent targets. RunDialogSelection now carries an optional recentTargets array, which library cards collect and forward through updated onRun callbacks. SubmitPlaybookRunDialog accepts these targets and renders a "Suggested targets" section for quick re-selection. Parameter-count badges are removed from both library and run cards.

Changes

Recent targets tracking in playbook runs

Layer / File(s) Summary
Data contract and callback signatures
ui/frontend/src/playbooks/PlaybookBrowser.tsx
RunDialogSelection is extended with an optional recentTargets array. PlaybookLibrarySection and PlaybookLibraryCard callback types are updated to include recentTargets as an optional parameter.
Library card selection and callbacks
ui/frontend/src/playbooks/PlaybookBrowser.tsx
Library card's main selection handler, card menu "Run" action, and per-target buttons are updated to call onRun with recentTargets propagated from the card's context.
Run dialog with suggested targets
ui/frontend/src/playbooks/PlaybookBrowser.tsx
SubmitPlaybookRunDialog gains an optional recentTargets prop and conditionally renders a "Suggested targets" section that updates runTarget when a suggestion is clicked.
Page integration and wiring
ui/frontend/src/playbooks/PlaybookBrowser.tsx
PlaybooksListPage extracts recentTargets from card callback selections and passes it into the run dialog props.
Remove parameter-count badges
ui/frontend/src/playbooks/PlaybookBrowser.tsx
Parameter-count badges are removed from library card and playbook run card UI.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the two main changes: removing parameter count badges and relocating recent targets functionality into the modal dialog.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ui-pb
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch ui-pb

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@moshloop moshloop enabled auto-merge (squash) May 21, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant