Skip to content

feat(plugin): support plugin-defined roles#3113

Merged
moshloop merged 4 commits into
mainfrom
feat/plugin-roles
May 21, 2026
Merged

feat(plugin): support plugin-defined roles#3113
moshloop merged 4 commits into
mainfrom
feat/plugin-roles

Conversation

@adityathebe
Copy link
Copy Markdown
Member

Plugins can now declare roles in their manifest and Mission Control resolves matching plugin-role:<plugin>:<role> permissions during invocation.

Mission Control still only enforces invoke:<plugin>:<operation> for access, then forwards any resolved roles in the short-lived invocation JWT.

The plugin SDK exposes those roles to gRPC and HTTP operation handlers so plugins can apply their own role-aware authorization.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 18, 2026

Warning

Rate limit exceeded

@adityathebe has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 3 minutes and 57 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 09575026-03f3-4ae3-ac65-dfc2580a7a58

📥 Commits

Reviewing files that changed from the base of the PR and between 3876562 and a644b4b.

⛔ Files ignored due to path filters (1)
  • plugin/proto/plugin.pb.go is excluded by !**/*.pb.go
📒 Files selected for processing (10)
  • AGENTS.md
  • auth/plugin_invocation.go
  • plugin/controller/controller.go
  • plugin/controller/proxy.go
  • plugin/controller/roles.go
  • plugin/proto/plugin.proto
  • plugin/runtime/invoke.go
  • plugin/sdk/caller_context.go
  • plugin/sdk/sdk.go
  • plugin/sdk/server.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/plugin-roles
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch feat/plugin-roles

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@adityathebe adityathebe mentioned this pull request May 18, 2026
3 tasks
@adityathebe adityathebe requested a review from moshloop May 18, 2026 09:25
@adityathebe adityathebe force-pushed the feat/plugin-roles branch 2 times, most recently from 071012d to 8e9dbd7 Compare May 20, 2026 06:00
@moshloop moshloop enabled auto-merge (squash) May 21, 2026 09:13
Expose plugin roles from the invocation token to both gRPC and HTTP operation handlers. This lets plugin authors inspect assigned roles through InvokeCtx or HTTP context helpers while Mission Control continues to enforce only operation invocation permissions.
@moshloop moshloop merged commit 93a892f into main May 21, 2026
10 checks passed
@moshloop moshloop deleted the feat/plugin-roles branch May 21, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants