Pr/new plugins#3069
Open
moshloop wants to merge 8 commits into
Open
Conversation
Add HTML login form for basic authentication with support for both HTML and JSON responses. Implement logout endpoint, bearer token auto-detection in browser login, and improved token management. Key changes: - Add ShowBasicLoginForm and BasicLogout handlers for basic auth - Implement sanitizeNext and wantsHTML helpers for secure redirects - Add rejectUnauthenticated to handle browser vs API client responses - Extract bearer tokens with scope counting and audience matching - Add browser teardown with graceful escalation (CDP close → SIGTERM → SIGKILL) - Implement token auto-detection with configurable wait timeout - Add context add command with automatic token resolution - Refactor RandomBase64 to panic on error instead of returning error - Replace custom StringList type with pq.StringArray in OIDC models - Add BuildCommit global variable - Fix /end_session endpoint name in skip auth paths - Improve HTTP client observability in OIDC client BREAKING CHANGE: RandomBase64 now panics on crypto/rand failure instead of returning an error
…ands Add comprehensive CLI support for access control management and playbook operations: - New `access` command hierarchy with subcommands for users, groups, roles, and matrix view - Support for listing, getting, and filtering external users, groups, and roles - Access matrix visualization with optional group expansion - New `playbook list` command to enumerate available playbooks - Enhanced `playbook run` to support both local YAML and remote API-based execution - Remote playbook execution with polling, parameter passing, and status tracking - New `plugin` command to invoke plugin operations directly - Refactored `catalog` commands using clicky entity framework for consistent UX - Added catalog tree visualization with relationship traversal - Enhanced catalog get with sections for changes, insights, access logs, and playbook runs - New database queries for access control and playbook listing - SDK client methods for playbook operations and HTML response detection - Comprehensive test coverage for CLI helpers and SDK functionality Breaking changes: - `catalog query` is now an alias for `catalog list --query` - Catalog command structure reorganized under clicky entity framework
…ctions, plugin types, and catalog improvements Add support for Access and AccessLogs section types in applications with corresponding UI filters and data structures. Introduce Plugin resource type for binary-backed Mission Control plugins with spec and status. Refactor FacetOptions to use embedded FacetRenderOptions struct. Add PDF configuration support to views. Enhance playbook listing to support fetching all playbooks without target filters. Add catalog report generation, config relationships, and bulk delete endpoints. Improve artifact handling with config change support and simplified blob-based downloads. Update OpenAPI schemas and CRDs accordingly. BREAKING CHANGE: FacetOptions now embeds FacetRenderOptions instead of having PDFOptions field; playbook list endpoint now allows optional target parameters instead of requiring exactly one.
- Add .gavel.yaml configuration for betterleaks linting with rules to ignore kubernetes secrets and API keys in deployment files - Update flanksource/clicky from v1.21.4 to v1.21.8 - Add new dependencies: flanksource/deps, fsnotify, golang-sql/sqlexp, hashicorp/go-plugin, hashicorp/golang-lru/v2, microsoft/go-mssqldb - Add GORM database drivers for MySQL, PostgreSQL, and SQL Server as direct dependencies - Expand .gitignore to exclude build artifacts, test reports, plugin outputs, and UI build files - Reorganize go.mod to move previously indirect dependencies to direct requires section - Update google.golang.org/protobuf from indirect to direct dependency
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 32461050 | Triggered | Generic Password | 48c468e | plugin/host/host_service.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Contributor
|
Important Review skippedToo many files! This PR contains 289 files, which is 139 over the limit of 150. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (11)
📒 Files selected for processing (289)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if raw == "" { | ||
| return "/ui" | ||
| } | ||
| if !strings.HasPrefix(raw, "/") || strings.HasPrefix(raw, "//") { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.