fix: use valid mission control connection type label

[adityathebe]

Kubernetes label selectors cannot use the existing missioncontrol/connectionType label key because the name segment contains uppercase characters.

Rename the label to mission-control/connection-type so mission-control connection configs can be selected using valid Kubernetes label selector syntax.

[coderabbitai]

Warning

Rate limit exceeded

@adityathebe has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 52 minutes and 33 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b90e8617-5919-4c2c-a9a1-eae6a220fefd

📥 Commits

Reviewing files that changed from the base of the PR and between 860d5f0 and 4d9869e.

📒 Files selected for processing (1)

• scrapers/kubernetes/mission_control.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/mission-control-connection-type-label

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch fix/mission-control-connection-type-label

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Benchstat

Base: 860d5f05121d8b326d27712426dd2db331d6e6b6
Head: 4d9869e80bc2e62805e4d72b9e65a81c3396b88d

📊 1 minor regression(s) (all within 5% threshold)

Benchmark	Base	Head	Change	p-value
BenchSaveResultsUpdateUnchanged/N=1000-4	11.51Mi	11.52Mi	+0.10%	0.015

Full benchstat output

goos: linux
goarch: amd64
pkg: github.com/flanksource/config-db/bench
cpu: AMD EPYC 9V74 80-Core Processor                
                                         │ bench-base.txt │           bench-head.txt           │
                                         │     sec/op     │    sec/op     vs base              │
BenchSaveResultsSeed/N=1000-4                965.7m ± 44%   956.5m ± 44%       ~ (p=0.818 n=6)
BenchSaveResultsUpdateUnchanged/N=1000-4     103.2m ±  3%   104.9m ±  8%       ~ (p=0.310 n=6)
BenchSaveResultsUpdateChanged/N=1000-4        1.047 ±  2%    1.049 ±  3%       ~ (p=0.589 n=6)
geomean                                      470.9m         472.1m        +0.26%

                                       │ bench-base.txt │           bench-head.txt           │
                                       │      MB/s      │    MB/s     vs base                │
BenchSaveResultsSeed/N=1000-4              0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
BenchSaveResultsUpdateChanged/N=1000-4     0.000 ± 0%     0.000 ± 0%       ~ (p=1.000 n=6) ¹
geomean                                               ²               +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                         │ bench-base.txt │           bench-head.txt           │
                                         │      B/op      │     B/op      vs base              │
BenchSaveResultsSeed/N=1000-4                36.32Mi ± 0%   36.27Mi ± 0%       ~ (p=0.240 n=6)
BenchSaveResultsUpdateUnchanged/N=1000-4     11.51Mi ± 0%   11.52Mi ± 2%  +0.10% (p=0.015 n=6)
BenchSaveResultsUpdateChanged/N=1000-4       75.27Mi ± 0%   75.28Mi ± 0%       ~ (p=1.000 n=6)
geomean                                      31.57Mi        31.56Mi       -0.00%

                                         │ bench-base.txt │          bench-head.txt           │
                                         │   allocs/op    │  allocs/op   vs base              │
BenchSaveResultsSeed/N=1000-4                 442.4k ± 0%   442.3k ± 0%       ~ (p=0.190 n=6)
BenchSaveResultsUpdateUnchanged/N=1000-4      130.0k ± 0%   130.0k ± 2%       ~ (p=0.128 n=6)
BenchSaveResultsUpdateChanged/N=1000-4        914.0k ± 1%   914.0k ± 1%       ~ (p=0.818 n=6)
geomean                                       374.6k        374.6k       -0.00%

                                         │ bench-base.txt │         bench-head.txt          │
                                         │      B/s       │     B/s       vs base           │
BenchSaveResultsUpdateUnchanged/N=1000-4     9.766Ki ± 0%   9.766Ki ± 0%  ~ (p=1.000 n=6) ¹
¹ all samples are equal