This repository was archived by the owner on May 19, 2025. It is now read-only.
Open
Conversation
BrocksiNet
reviewed
Sep 3, 2020
| // try to save it | ||
| try { | ||
|
|
||
| if(isset($_FILES['icon']['name']) && (file_exists($_FILES['icon']['tmp_name']))) { |
Contributor
There was a problem hiding this comment.
could you pls use php-cs and check your files
Author
There was a problem hiding this comment.
Sorry I don't know yet how to do this.
There was a problem hiding this comment.
Coding style checks should actually be part of the CI and break a build if the coding style doesn't match with the provided code. Is this about the default Magento coding standard or some else?
BrocksiNet
reviewed
Sep 3, 2020
Comment on lines
+145
to
+146
| } | ||
| else{ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small first contribution