Skip to content

Conversation

@RFCreate
Copy link
Contributor

@RFCreate RFCreate commented Oct 10, 2024

Add missing xcb_icccm_wm_hints_t *hints pointer and the attribute hints->flags from the wlroots C source code to this repo.

EDIT: This is incomplete, please read next comment.

@RFCreate RFCreate changed the title Add xcb_icccm_wm_hints_t *hints->flags attributes Add xcb_icccm_wm_hints_t attributes Oct 19, 2024
@RFCreate
Copy link
Contributor Author

Finally found all attributes of the xcb_icccm_wm_hints_t struct. Now added to this PR alongside with the Hints class with all the properties.

@flacjacket
Copy link
Owner

Thanks!

@RFCreate
Copy link
Contributor Author

@flacjacket what is the xcbcommon error?

@flacjacket
Copy link
Owner

@RFCreate That looks like we are just trying to use the wrong python-xkbcommon version when packaging, there were some changes there that means we need to be careful with the version that we pick. I can look into that since it happens on master, and it ultimately doesn't fail in the CI build (since our docker container has a different xkbcommon that is compatible), so this change should be fine.

@heuer
Copy link
Contributor

heuer commented Jan 15, 2025

I guess it's the same problem as for #211.

I believe @jwijenbergh fixed the problem in his 0.18 branch but I cannot find the commit. I believe he fixed the xkbcommon version to a specific version, but I am not sure.

@RFCreate
Copy link
Contributor Author

RFCreate commented Jan 15, 2025

Could this suggestion qtile/qtile#4946 work?

pip3 install 'xkbcommon<1.1'

@RFCreate
Copy link
Contributor Author

RFCreate commented Jan 15, 2025

Fixed in #223

@flacjacket @heuer

@flacjacket flacjacket merged commit f0031ea into flacjacket:main Jan 16, 2025
19 of 27 checks passed
@RFCreate RFCreate deleted the hints_flags branch February 3, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants