Skip to content

add clang CI, fix warnings #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flipflip8952 merged 1 commit into from
Oct 20, 2025
Merged

add clang CI, fix warnings #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions .github/ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,38 @@ function build_colcon_debug
ros2 pkg executables fixposition_driver_ros2
}

# ----------------------------------------------------------------------------------------------------------------------

TITLES["build_colcon_release_clang"]="Build colcon (release, with ROS2, clang instead of GCC)"
function build_colcon_release_clang
{
local buildname=${FPSDK_IMAGE}_build_colcon_release_clang
${FP_SRC_DIR}/create_ros_ws.sh ${buildname} || return 1
cd ${FP_SRC_DIR}/${buildname}
export CC=clang CXX=clang++
colcon build || return 1
set +u
source install/setup.bash
set -u
ros2 pkg executables fixposition_driver_ros2
unset CC CXX
}

TITLES["build_colcon_debug_clang"]="Build colcon (debug, with ROS2, clang instead of GCC)"
function build_colcon_debug_clang
{
local buildname=${FPSDK_IMAGE}_build_colcon_debug_clang
${FP_SRC_DIR}/create_ros_ws.sh -d ${buildname} || return 1
cd ${FP_SRC_DIR}/${buildname}
export CC=clang CXX=clang++
colcon build || return 1
set +u
source install/setup.bash
set -u
ros2 pkg executables fixposition_driver_ros2
unset CC CXX
}

########################################################################################################################

# Always
Expand All @@ -162,6 +194,9 @@ elif [ "${ROS_DISTRO}" = "humble" -o "${ROS_DISTRO}" = "jazzy" ]; then

do_step build_colcon_release || true # continue
do_step build_colcon_debug || true # continue

do_step build_colcon_release_clang || true # continue
do_step build_colcon_debug_clang || true # continue
fi

########################################################################################################################
Expand Down
2 changes: 1 addition & 1 deletion fixposition_driver_ros2/src/fixposition_driver_node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,7 @@ void FixpositionDriverNode::ProcessOdometryData(const OdometryData& odometry_dat

// Output jump warning
if (params_.cov_warning_ && odometry_data.valid && jump_detector_.Check(odometry_data)) {
RCLCPP_WARN(logger_, jump_detector_.warning_.c_str());
RCLCPP_WARN(logger_, "%s", jump_detector_.warning_.c_str());
PublishJumpWarning(jump_detector_, jump_pub_);
}

Expand Down
Loading