bug/dupe-orders#158
Open
fivetran-catfritz wants to merge 7 commits into
Open
Conversation
fivetran-catfritz
added
docs:ready
fivetran-savage
approved these changes
Jun 1, 2026
…pify into bug/dupe-orders mege
| [PR #158](https://github.com/fivetran/dbt_shopify/pull/158) includes the following update: | ||
|
|
||
| ## Bug Fix | ||
| - Fixes duplicate `order_line_id` values in `shopify_gql__order_lines` caused by order lines that belong to multiple fulfillment orders. `int_shopify_gql__order_line` now aggregates `stg_shopify_gql__fulfillment_order_line_item` to the order line grain before joining, so `fulfillable_quantity` correctly reflects the total remaining quantity across all fulfillment orders rather than producing duplicate rows. |
Contributor
There was a problem hiding this comment.
Probably less important for a pre-release, but in the interest of making changelogs more concise/less technical, I'm wondering if all the join details are necessary. Might just cut all but the first sentence.
Contributor
Author
There was a problem hiding this comment.
Agreed I will update.
Co-authored-by: Savage Fivetran <sarah.savage@fivetran.com>
fivetran-savage
approved these changes
Jun 9, 2026
Contributor
|
Approved for pre-release! |
fivetran-catfritz
added
pre-release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
int_shopify_gql__orderby filtering to include only the most recent visit per order, preventing duplicate visits in downstream models.Submission Checklist
downstream_model_column_countmacro?Changelog