feature/update_tiktok_ads_version#176
Merged
Merged
Conversation
fivetran-jamie
left a comment
fivetran-jamie
left a comment
Contributor
There was a problem hiding this comment.
Looks awesome, just some changelog comments!
Comment on lines
+5
to
+6
| ## Upstream Dependency Change | ||
| - Increases the required TikTok Ads package to version [1.3.0](https://github.com/fivetran/dbt_tiktok_ads/blob/main/CHANGELOG.md#dbt_tiktok_ads-v130) |
Contributor
There was a problem hiding this comment.
Not sure we need to include this in the changelog -- whatcha think?
Contributor
Author
There was a problem hiding this comment.
Don't dbt users need to know that they need to update their tiktok_ads version or is that automatic?
Contributor
There was a problem hiding this comment.
Automatic since ad_reporting itself installs tiktok_ads!
fivetran-jamie
approved these changes
May 18, 2026
fivetran-jamie
left a comment
fivetran-jamie
left a comment
Contributor
There was a problem hiding this comment.
Approved with one edit to the changelog!
Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
This PR addresses the following Issue/Feature(s):
Summary of changes:
tiktok_adsversion to 1.3.0Submission Checklist
Changelog