fix: NO_REPLY check should use trim + word-boundary regex#86
Merged
Conversation
NO_REPLY with trailing text or whitespace was bypassing exact match and
getting delivered to users. Changed both cron-runner.ts and stream-relay.ts
to use output.trim().startsWith("NO_REPLY").
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Tighten NO_REPLY match from startsWith to word-boundary regex /^NO_REPLY(\s|$)/ to avoid false positives on NO_REPLY_EXTRA etc. - Add negative test for NO_REPLY substring prefix (NO_REPLY_EXTRA) - Remove unnecessary null-coalescing on non-nullable accumulated var - Fix sendTyping to skip DM chats (pre-existing test failure) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add content assertion to NO_REPLY_EXTRA boundary test - Update plan to reflect regex approach (was stale from startsWith era) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NO_REPLY\n\nExplanation...)trim()+ word-boundary regexcron-runner.tsandstream-relay.tsCloses #80
Test plan
NO_REPLYexact — swallowedNO_REPLY\n\nSome text— swallowedNO_REPLY— swallowedNO_REPLY_EXTRA— NOT swallowed (word boundary)🤖 Generated with Claude Code