Skip to content

Conversation

@AlexCaston
Copy link
Contributor

@AlexCaston AlexCaston commented Sep 29, 2025

With this PR the node environment now supports response streaming by returning a Readable as the body from the fission function.

This environment can be tried with:

fission environment create --name nodejs-streaming --image ghcr.io/a-safe-digital/node-streaming-env:0.1.3

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds response streaming support to the Node.js environment by allowing fission functions to return a Readable stream as the response body, which is then piped directly to the HTTP response.

  • Imports the Readable class from node:stream module
  • Adds conditional logic to handle Readable streams by piping them to the response instead of sending them directly

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@AlexCaston AlexCaston force-pushed the feat/node-response-streaming branch from 66b739c to a63ea1f Compare September 30, 2025 07:36
@AlexCaston
Copy link
Contributor Author

AlexCaston commented Sep 30, 2025

Hi @sanketsudake,

I just fixed the style issues mentioned by copilot.

@sanketsudake sanketsudake merged commit 2349b43 into fission:master Sep 30, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants