Skip to content

Conversation

@tosone
Copy link
Contributor

@tosone tosone commented Jan 21, 2021

No description provided.

@vishal-biyani
Copy link
Member

Hi @tosone

  • I see quite a few files with changes to path with comments "File renamed without changes." I think those are by mistake here
  • I don't see any difference in server.java or in the example hello world class - so technically would the same Spring environment which is available would work with Gradle built functions too?
  • There is a file java-maven-spring/examples/java/specs/README which seems misplaced
  • Also changes to file environments-ui/src/resources/environments.json needs fixing - there are many changes which are not needed.

Copy link
Member

@vishal-biyani vishal-biyani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments in PR I think this needs some work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants