Fix - owner tip on 11.1; Task 178 service goods#677
Open
AVPavel wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
market-gr
StefanKert
added
area-sign
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a POS sends a charge item with Tip ChargeItemCase and a taxable VAT rate on a
PointOfSaleReceipt(invoice type11.1), the middleware was mapping it tocategory1_95(Other Income Information). AADE rejects this combination with error 313 —category1_95is forbidden on invoice type11.1.The fix adds a guard in
GetIncomeClassificationCategoryType: when owner/company tip is detected on a Receipt type, the category is remapped tocategory1_3(Provision of Services Income), which is allowed on11.1. The VAT rate andE3_561_007classification type are preserved.The fix does not affect:
1.x,2.x) —category1_95remains correct thereV=8(employee tip) — separate concern, not in scope for this fixChanges in connection with #178 to ensure correct semantics.