Closed
Conversation
github-actions
Bot
added
market-gr
StefanKert
reviewed
Feb 16, 2026
StefanKert
reviewed
Feb 16, 2026
StefanKert
added
category-enhancement
volllly
previously requested changes
Feb 18, 2026
| var aadFactory = new AADEFactory(_masterDataConfiguration); | ||
| ======= | ||
| var aadFactory = new AADEFactory(_masterDataConfiguration, _receiptBaseAddress); | ||
| >>>>>>> main |
Contributor
There was a problem hiding this comment.
issue: There's a merge conflict merged into the PR here 😅
mariananton18
approved these changes
Mar 3, 2026
Member
|
Closing cause merged already |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes
processReceiptmethod to look first of all for the cancellation case (void + transportInfo + delivery note receiptCase).Detail
The cancellation will only be done if the 3 flags are present:
ReceiptCaseFlags.Void,ReceiptCase.DeliveryNote,ReceiptCaseFlagsGR.hasTransportInformation, and if the previous receipt reference is present.If the conditions are complete and there is no missing critical information (mark, VAT number), then the cancel delivery note method from
MyDATASCU.cswill cover the logic of sending the information to myDATA and the response parsing.The VAT number sent in the URL:
$"/myDataProvider/CancelDeliveryNote?mark={mark}&entityVatNumber={vatNumber}"is only made out of the numeric part.
The current tests cover only the cases where some of the flags or critical information are missing. No request mock.
Fixes # 119 Market-GR