Skip to content

Conversation

@AHGIJMKLKKZNPJKQR
Copy link
Member

Description

Describe your changes.

Motivation and Context

Why is this change required? What problem does it solve? If it fixes an open
issue, please link to the issue here.

Documentation impact

  • Documentation update required
  • Documentation updated in another PR
  • No documentation update required

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Fishjam server SDK to version 0.24.0, primarily refactoring OpenAPI-generated model class names to be more concise and removing deprecated default values for configuration options.

Key changes include:

  • Renaming verbose OpenAPI model classes (e.g., RoomConfigRoomTypeRoomType, PeerOptionsWebRTCMetadataWebRTCMetadata)
  • Removing default values from RoomConfig fields (room_type, video_codec) and AgentOutput fields (audio_format, audio_sample_rate)
  • Removing the enable_simulcast field from PeerOptions and PeerOptionsWebRTC

Reviewed changes

Copilot reviewed 21 out of 22 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pyproject.toml Version bumped from 0.23.0 to 0.24.0
fishjam/room/init.py Updated exports to use renamed model classes
fishjam/api/_fishjam_client.py Updated imports and removed enable_simulcast field from PeerOptions class
fishjam/_openapi_client/models/*.py Renamed multiple OpenAPI model classes and removed default values
tests/test_room_api.py Updated test code to use renamed classes and removed enable_simulcast from test
examples/room_manager/*.py Updated example code to use renamed classes and removed enable_simulcast configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AHGIJMKLKKZNPJKQR AHGIJMKLKKZNPJKQR merged commit 36786dc into main Dec 18, 2025
6 checks passed
@AHGIJMKLKKZNPJKQR AHGIJMKLKKZNPJKQR deleted the release-0.24.0 branch December 18, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants