Gemini code docs fixes #216
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes documentation issues in the Gemini Live integration tutorials and API documentation across multiple versions (0.23.0, 0.24.0, and latest).
Key changes:
- Corrected Python import statements to use
from fishjam import AgentOptionsinstead of incorrect imports fromfishjam.peerandfishjam.agent - Added proper TypeScript import for
Modalityfrom@google/genaiand removed the local enum definition - Updated API documentation text for
AgentOptionsclass to clarify it's for "Agent Peer" instead of "WebRTC Peer"
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| versioned_docs/version-0.24.0/tutorials/gemini-live-integration.mdx | Fixed Python imports and TypeScript Modality enum/import |
| versioned_docs/version-0.24.0/api/server-python/fishjam/index.md | Updated AgentOptions description from "WebRTC Peer" to "Agent Peer" |
| versioned_docs/version-0.23.0/tutorials/gemini-live-integration.mdx | Fixed Python imports and TypeScript Modality enum/import (same as 0.24.0) |
| versioned_docs/version-0.23.0/api/server-python/fishjam.md | Updated AgentOptions description from "WebRTC Peer" to "Agent Peer" |
| docs/tutorials/gemini-live-integration.mdx | Fixed Python imports and TypeScript Modality enum/import (same as versioned docs) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
versioned_docs/version-0.24.0/api/server-python/fishjam/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes FCE-2507