Fix #5113: Add strikethrough extension to markdown#5274
Fix #5113: Add strikethrough extension to markdown#5274bschwede wants to merge 1 commit intofisharebest:mainfrom
Conversation
|
What do you think about other extensions:
|
|
We currently use ckEditor to edit HTML notes. We do not have a similar editor for markdown - but I plan to add one. We should also consider that we may need to change markdown library in the future. So, I do not want to deviate too much from the "standard" (i.e. CommonMark). This will keep our options open for other libraries. If we add any extensions, then we have to be confident that they will be supported by other libraries. So, I can't accept this PR until I have time to research which other libraries can also support it. It would be disappointing if we cannot use an interactive editor because it does not support strikethrough. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5274 +/- ##
=========================================
Coverage 35.20% 35.20%
Complexity 11236 11236
=========================================
Files 1159 1159
Lines 48103 48104 +1
=========================================
+ Hits 16934 16935 +1
Misses 31169 31169 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for the insides. Your concerns are understandable. It makes sense not to lose sight of the big picture and don't get caught up in feature fever. Do you want to use the same editor for html and markdown notes or do you also consider a non-wysiwyg editor just with syntax highlighting? |
Fix #5113