Skip to content

Add default SVG silhouette icon#5088

Open
ekdahl wants to merge 2 commits intofisharebest:mainfrom
ekdahl:svg-silhouettes
Open

Add default SVG silhouette icon#5088
ekdahl wants to merge 2 commits intofisharebest:mainfrom
ekdahl:svg-silhouettes

Conversation

@ekdahl
Copy link
Copy Markdown
Contributor

@ekdahl ekdahl commented Dec 28, 2024

Should not affect supplied themes, until "content" CSS property is unset for parent element. Suggestion for #5049.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 28, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.20%. Comparing base (2b3a3e6) to head (ed12be6).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5088   +/-   ##
=========================================
  Coverage     35.20%   35.20%           
  Complexity    11236    11236           
=========================================
  Files          1159     1159           
  Lines         48108    48108           
=========================================
  Hits          16937    16937           
  Misses        31171    31171           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fisharebest
Copy link
Copy Markdown
Owner

I like the idea of using the SVG icons for the silhouette image.

Do you think the "solid" icon is better for this? https://fontawesome.com/icons/user?f=classic&s=solid

We should use the same image in the chart boxes.

Perhaps create a new view (e.g. resources/views/silhouette.phtml) that we can use for both.

I see that the code for thumbnail images / silhouettes is slightly different for chartboxes and the individual page. I need to make this consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants