Add default SVG silhouette icon#5088
Open
ekdahl wants to merge 2 commits intofisharebest:mainfrom
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5088 +/- ##
=========================================
Coverage 35.20% 35.20%
Complexity 11236 11236
=========================================
Files 1159 1159
Lines 48108 48108
=========================================
Hits 16937 16937
Misses 31171 31171 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
I like the idea of using the SVG icons for the silhouette image. Do you think the "solid" icon is better for this? https://fontawesome.com/icons/user?f=classic&s=solid We should use the same image in the chart boxes. Perhaps create a new view (e.g. resources/views/silhouette.phtml) that we can use for both. I see that the code for thumbnail images / silhouettes is slightly different for chartboxes and the individual page. I need to make this consistent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should not affect supplied themes, until "content" CSS property is unset for parent element. Suggestion for #5049.