Skip to content

refactor(client)!: remove support for implicit HTTP client#605

Open
c00w wants to merge 1 commit into
firstof9:mainfrom
c00w:implicit
Open

refactor(client)!: remove support for implicit HTTP client#605
c00w wants to merge 1 commit into
firstof9:mainfrom
c00w:implicit

Conversation

@c00w
Copy link
Copy Markdown
Contributor

@c00w c00w commented Jun 3, 2026

Core and External HACS both now explicitly pass the http client

This has some complexity, in particular, 1) we make ws_start require a session, and 2) We made it async.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 3, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 219c0c56-8227-4797-bbca-7e8140cc5505

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@c00w c00w force-pushed the implicit branch 3 times, most recently from 10ce80b to 2390b74 Compare June 3, 2026 01:41
@c00w c00w marked this pull request as ready for review June 3, 2026 01:43
@firstof9 firstof9 changed the title Remove support for implicit HTTP client. refactor(client)!: remove support for implicit HTTP client Jun 3, 2026
@firstof9
Copy link
Copy Markdown
Owner

firstof9 commented Jun 3, 2026

Sorry I was cleaning up some tests before you started this.

@c00w
Copy link
Copy Markdown
Contributor Author

c00w commented Jun 3, 2026

@firstof9 nw I can rebase

Core and External HACS both now explicitly pass the http client
@github-actions github-actions Bot added the breaking-change Breaking Changes label Jun 3, 2026
@c00w
Copy link
Copy Markdown
Contributor Author

c00w commented Jun 3, 2026

@firstof9 - done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change Breaking Changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants