chore: bump x25519-dalek and rand dependencies#119
Open
thomaseizinger wants to merge 2 commits intomasterfrom
Open
chore: bump x25519-dalek and rand dependencies#119thomaseizinger wants to merge 2 commits intomasterfrom
x25519-dalek and rand dependencies#119thomaseizinger wants to merge 2 commits intomasterfrom
Conversation
69c1ca0 to
d2ae1b5
Compare
jamilbk
approved these changes
Oct 2, 2025
Member
Author
|
I need to do another audit as to when these new randomness functions can fail. |
Member
Author
So it seems like that these can only fail when OS-rng is used which it is for some of the crypto aspects of WireGuard. I don't know about the old behaviour but the new one will panic. I've inquired with upstream: dalek-cryptography/curve25519-dalek#731 (comment) |
klochowicz
approved these changes
Nov 18, 2025
Member
Author
|
I am gonna delay this for as long as we can to avoid the minor version bump. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, both
randandx25519-dalekare "exposed" dependencies ofboringtun. In other words, they are part of our public API and thus bumping them by a minor version is a backwards-incompatible Rust API change. The wire format is unaffected.In order to bump to the latest version of
randin Firezone, we need to updateboringtunto the latestrandfirst.For our purposes, this is fine because we only directly depend on
boringtun. Hence, we can adapt our call-sites to these new APIs easily. I don't know how many other users of our fork are out there because if they want to replace their version ofboringtundeep down in their dependency tree, then going forward, this will no longer work for them.We've been delaying making any kind of breaking changes to the API for a while even though it would be nice to e.g. improve the errors and remove some of the unused ones.
Once this PR is in, we can do that because the version bump to 0.7 now allows breaking changes.