Skip to content

Conversation

@mabels
Copy link
Contributor

@mabels mabels commented Dec 23, 2025

Summary by CodeRabbit

  • Chores
    • Updated CI/CD deployment workflow retry mechanism to improve build reliability.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 23, 2025

Walkthrough

Refactored retry logic in the deployment workflow from GitHub Actions step-level error handling to a CLI tool invocation. Removed the secondary deployment attempt step and replaced the test command with pnpm exec core-cli retry to centralize retry behavior.

Changes

Cohort / File(s) Summary
Deployment retry refactoring
.github/workflows/ci-core-cf-deploy.yaml
Removed step-level retry logic (id: attempt1, continue-on-error: true, and secondary deployment step block). Wrapped test command invocation with pnpm exec core-cli retry wrapper to consolidate retry behavior into CLI tooling.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'add the correct retry logic' directly describes the main change: replacing error-tolerant duplicate deployment attempts with proper retry logic using pnpm exec core-cli retry.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch mabels/cf-deploy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/ci-core-cf-deploy.yaml (1)

43-43: Verified: good refactor, but consider making retry parameters explicit.

The centralized retry logic via core-cli retry is cleaner than step-level GitHub Actions retry logic. The command supports configurable retry attempts (--retry, default: 2) and timeout (--timeout, default: 0 = no timeout).

The current line uses these defaults implicitly. For clarity, consider adding --retry 2 to the command so future maintainers know the exact retry behavior without checking the CLI defaults.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6481026 and ad3ef46.

📒 Files selected for processing (1)
  • .github/workflows/ci-core-cf-deploy.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: CI Core

@mabels mabels merged commit aaa1cc4 into main Dec 23, 2025
2 checks passed
@mabels mabels deleted the mabels/cf-deploy branch December 23, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants