Improve how we pick the "default" native symbol for the assembly view when double-clicking a call node with multiple native symbols #5788
+265
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5788 +/- ##
=======================================
Coverage 85.56% 85.57%
=======================================
Files 320 320
Lines 31419 31448 +29
Branches 8649 8570 -79
=======================================
+ Hits 26884 26911 +27
- Misses 4104 4106 +2
Partials 431 431 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
canova
reviewed
Jan 30, 2026
Contributor
Author
|
Huh, I forgot to land this! |
…"entry index" only at the end of the function.
… symbol with the highest sample count.
mstange
force-pushed
the
assembly-view-open-heaviest
branch
from
fa07f06 to
0693702
Compare
canova
added a commit
that referenced
this pull request
Feb 11, 2026
Changes: [Valentin Gosu] Make extractGeckoLogs() not fake the D/ log level if the log module already contains it (#5811) [Markus Stange] Improve how we pick the "default" native symbol for the assembly view when double-clicking a call node with multiple native symbols (#5788) [fatadel] Use base 10 when calculating memory (#5810) [Markus Stange] Remove unused function getEmptySamplesTableWithResponsiveness (#5825) [arai-a] Make the dark-mode selected timeline background more similar to non-selected color/contrast, and use slightly brigher colors for the timeline and category (#5823) [Nazım Can Altınova] 🔃 Sync: l10n -> main (February 11, 2026) (#5827) And special thanks to our localizers: de: Ger de: Michael Köhler el: Jim Spentzos en-CA: chutten en-CA: Saurabh en-GB: Ian Neal es-CL: ravmn ia: Martijn Dekker ia: Melo46 it: Francesco Lodolo [:flod] nl: Mark Heijl pt-BR: Marcelo Ghelman ru: Valery Ledovskoy sv-SE: Andreas Pettersson tr: Nazım Can Altınova tr: Selim Şumlu zh-CN: Olvcpr423 zh-CN: wxie zh-TW: Pin-guang Chen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Production | Deploy preview (Double click on the fifth root node,
Ion: BinaryConstraint.prototype.input)This PR makes it so we show the assembly code for the native symbol with the highest "total" for the double-clicked call node.
We don't reorder the list so that the list is always the same regardless of the current preview selection. The preview selection only influences which item in the list gets displayed by default. For example, in the deploy preview, you can create a preview selection so that double-clicking the
Ion: BinaryConstraint.prototype.inputshows the first native symbol.