Reduce allocations for getStackLineInfo + getStackAddressInfo#5761
Open
mstange wants to merge 1 commit intofirefox-devtools:mainfrom
Open
Reduce allocations for getStackLineInfo + getStackAddressInfo#5761mstange wants to merge 1 commit intofirefox-devtools:mainfrom
mstange wants to merge 1 commit intofirefox-devtools:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5761 +/- ##
==========================================
+ Coverage 85.57% 85.62% +0.04%
==========================================
Files 320 321 +1
Lines 31448 31552 +104
Branches 8570 8694 +124
==========================================
+ Hits 26911 27015 +104
Misses 4106 4106
Partials 431 431 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mstange
force-pushed
the
compact-stack-line-info
branch
4 times, most recently
from
d446334 to
5858c75
Compare
mstange
force-pushed
the
compact-stack-line-info
branch
3 times, most recently
from
0dc54ef to
d9058d2
Compare
mstange
force-pushed
the
compact-stack-line-info
branch
3 times, most recently
from
8819001 to
b9e9cfd
Compare
Before: https://share.firefox.dev/3NnthpO After: https://share.firefox.dev/45dMNv1 getStackLineInfo now allocates 46MB instead of 220MB (4.8x reduction), and takes 146ms instead of 338ms (2.3x reduction), when opening the source view for mozjemalloc.cpp on https://share.firefox.dev/3NnzEcF
mstange
force-pushed
the
compact-stack-line-info
branch
from
b9e9cfd to
bdda4d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production | Deploy preview
On large profiles, opening the source view can cause large allocations because we create
Setobjects for many stacks. In this PR I've experimented with a more compact storage of a collection of sets.Before: https://share.firefox.dev/3NnthpO
After: https://share.firefox.dev/45dMNv1
getStackLineInfonow allocates 46MB instead of 220MB (4.8x reduction), and takes 146ms instead of 338ms (2.3x reduction), when opening the source view formozjemalloc.cppon https://share.firefox.dev/3NnzEcF.