Fix drag-and-drop overlay triggering during internal drags#5750
Open
Weberpcc wants to merge 3 commits intofirefox-devtools:mainfrom
Open
Fix drag-and-drop overlay triggering during internal drags#5750Weberpcc wants to merge 3 commits intofirefox-devtools:mainfrom
Weberpcc wants to merge 3 commits intofirefox-devtools:mainfrom
Conversation
Weberpcc
force-pushed
the
fix-dnd-overlay-edge-case
branch
from
5ae0e09 to
32fa73b
Compare
canova
requested changes
Jan 11, 2026
Member
canova
left a comment
canova
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I haven't looked at the code, so I don't have any feedback on that yet. But have you tested the changes locally? I see that the deploy preview fails to load the homepage: https://deploy-preview-5750--perf-html.netlify.app/ See the devtools console for the error.
Please follow the contribution document to learn how to build and test locally. Also, please make sure that all the tests pass (see the aforementioned document).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an edge case where internal drags briefly triggered the
“Drop a saved profile here” overlay.
The selector logic has been tightened so new profile loading
is only allowed for external file drags.
Fixes #5750
While investigating #5710, I found that the root cause actually matches
the behavior described in #5750. This change fixes the underlying issue
causing the drag-and-drop overlay to trigger during internal drags.
Related to #5710.