Retain platform-specific timestamp field that are being added in bug 1961012#5446
Merged
julienw merged 2 commits intofirefox-devtools:mainfrom May 13, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5446 +/- ##
=======================================
Coverage 86.03% 86.03%
=======================================
Files 312 312
Lines 30365 30365
Branches 8299 8299
=======================================
Hits 26126 26126
Misses 3645 3645
Partials 594 594 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
julienw
added a commit
that referenced
this pull request
May 15, 2025
[Julien Wajsberg] Relax the check about chrome profiles (#5439) [Julien Wajsberg] Do not fail when the input isn't valid UTF-8 (#5426) [Markus Stange] Add the marker field types "flow-id" and "terminating-flow-id" to the set of types that store indexes in the string table (#5447) [Markus Stange] Retain platform-specific timestamp field that are being added in bug 1961012. (#5446) [Julien Wajsberg] Use the right allocations call tree when an allocations summary is selected (#5456) [Julien Wajsberg] Do not use a link to display the sourceURL if it's not a proper URL (#5454) And for locales: kab: ZiriSut zh-CN: Olvcpr423
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes us carry the fields added in bug 1961012 through into the processed format, and adds them to the type definitions.
The corresponding change to samply's simpleperf importer is in mstange/samply#560 .
I'm making use of the
startTimeAsClockMonotonicNanosecondsSinceBootfield in the merging script which I've put into #5448.Pasting the justification from the bug here: