Skip to content

Nicer import of chrome-trace profiles generated by gradle-profiler. #5360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fqueze wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Nicer import of chrome-trace profiles generated by gradle-profiler. #5360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffdba4a
Nicer import of chrome-trace profiles generated by gradle-profiler.
fqueze Feb 7, 2025
d46217c
Merge branch 'firefox-devtools:main' into import-gradle-profiler-chro…
fqueze Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 75 additions & 12 deletions src/profile-logic/import/chrome.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -948,6 +948,21 @@ function extractMarkers(
},
],
},
{
name: 'Text',
tooltipLabel: '{marker.name}',
tableLabel: '{marker.name} — {marker.data.text}',
chartLabel: '{marker.data.text}',
display: ['marker-chart', 'marker-table'],
data: [
{
key: 'text',
label: 'Description',
format: 'string',
searchable: true,
},
],
},
];

for (const [name, events] of eventsByName.entries()) {
Expand Down Expand Up @@ -1001,21 +1016,69 @@ function extractMarkers(
if (event.args && typeof event.args === 'object') {
argData = (event.args: any).data || null;
}
markers.name.push(stringTable.indexForString(name));

markers.category.push(otherCategoryIndex);
let newData = {};
const prefixes = [
'Apply build file',
'Apply initialization script',
'Apply plugin',
'Apply script',
'Apply settings file',
'Calculate build tree task graph',
'Calculate task graph',
'Configure build',
'Configure project',
'Compile build file',
'Compile script',
'Cross-configure project',
'Download',
'Evaluate settings',
'Execute countainer callback action',
'Execute',
'Executing',
'Finalize build cache configuration',
'Fingerprint transform inputs',
'Finish root build tree',
'Identifying work',
'Load build',
'Load projects',
'Notify afterEvaluate listeners',
'Notify beforeEvaluate listeners',
'Notify projectsEvaluated listeners',
'Notify projectsLoaded listeners',
'Notify task graph',
'Realize task',
'Register task',
'Resolve dependencies of',
'Resolve files of configuration',
'Resolve',
'Run init scripts',
'Run main tasks',
'Snapshot',
'Toolchain detection',
];
const prefix = prefixes.find((p) => name.startsWith(p));
if (prefix) {
newData.type = 'Text';
newData.text = name.slice(prefix.length + 1);
markers.name.push(stringTable.indexForString(prefix));
} else {
markers.name.push(stringTable.indexForString(name));

if (argData && 'type' in argData) {
argData.type2 = argData.type;
}
if (argData && 'category' in argData) {
argData.category2 = argData.category;
}
if (argData && 'type' in argData) {
argData.type2 = argData.type;
}
if (argData && 'category' in argData) {
argData.category2 = argData.category;
}

const newData = {
...argData,
type: name,
category: event.cat,
};
newData = {
...argData,
type: name,
category: event.cat,
};
}

// $FlowExpectError Opt out of Flow checking for this one.
markers.data.push(newData);
Expand Down
108 changes: 108 additions & 0 deletions src/test/unit/__snapshots__/profile-conversion.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334624,6 +334624,24 @@ Object {
"tableLabel": "{marker.data.type2}",
"tooltipLabel": "{marker.data.type2} - EventDispatch",
},
Object {
"chartLabel": "{marker.data.text}",
"data": Array [
Object {
"format": "string",
"key": "text",
"label": "Description",
"searchable": true,
},
],
"display": Array [
"marker-chart",
"marker-table",
],
"name": "Text",
"tableLabel": "{marker.name} — {marker.data.text}",
"tooltipLabel": "{marker.name}",
},
],
"misc": "",
"oscpu": "",
Expand Down Expand Up @@ -382999,6 +383017,24 @@ Object {
"tableLabel": "{marker.data.type2}",
"tooltipLabel": "{marker.data.type2} - EventDispatch",
},
Object {
"chartLabel": "{marker.data.text}",
"data": Array [
Object {
"format": "string",
"key": "text",
"label": "Description",
"searchable": true,
},
],
"display": Array [
"marker-chart",
"marker-table",
],
"name": "Text",
"tableLabel": "{marker.name} — {marker.data.text}",
"tooltipLabel": "{marker.name}",
},
],
"misc": "",
"oscpu": "",
Expand Down Expand Up @@ -431374,6 +431410,24 @@ Object {
"tableLabel": "{marker.data.type2}",
"tooltipLabel": "{marker.data.type2} - EventDispatch",
},
Object {
"chartLabel": "{marker.data.text}",
"data": Array [
Object {
"format": "string",
"key": "text",
"label": "Description",
"searchable": true,
},
],
"display": Array [
"marker-chart",
"marker-table",
],
"name": "Text",
"tableLabel": "{marker.name} — {marker.data.text}",
"tooltipLabel": "{marker.name}",
},
],
"misc": "",
"oscpu": "",
Expand Down Expand Up @@ -434204,6 +434258,24 @@ Object {
"tableLabel": "{marker.data.type2}",
"tooltipLabel": "{marker.data.type2} - EventDispatch",
},
Object {
"chartLabel": "{marker.data.text}",
"data": Array [
Object {
"format": "string",
"key": "text",
"label": "Description",
"searchable": true,
},
],
"display": Array [
"marker-chart",
"marker-table",
],
"name": "Text",
"tableLabel": "{marker.name} — {marker.data.text}",
"tooltipLabel": "{marker.name}",
},
],
"misc": "",
"oscpu": "",
Expand Down Expand Up @@ -437140,6 +437212,24 @@ Object {
"tableLabel": "{marker.data.type2}",
"tooltipLabel": "{marker.data.type2} - EventDispatch",
},
Object {
"chartLabel": "{marker.data.text}",
"data": Array [
Object {
"format": "string",
"key": "text",
"label": "Description",
"searchable": true,
},
],
"display": Array [
"marker-chart",
"marker-table",
],
"name": "Text",
"tableLabel": "{marker.name} — {marker.data.text}",
"tooltipLabel": "{marker.name}",
},
],
"misc": "",
"oscpu": "",
Expand Down Expand Up @@ -446084,6 +446174,24 @@ Object {
"tableLabel": "{marker.data.type2}",
"tooltipLabel": "{marker.data.type2} - EventDispatch",
},
Object {
"chartLabel": "{marker.data.text}",
"data": Array [
Object {
"format": "string",
"key": "text",
"label": "Description",
"searchable": true,
},
],
"display": Array [
"marker-chart",
"marker-table",
],
"name": "Text",
"tableLabel": "{marker.name} — {marker.data.text}",
"tooltipLabel": "{marker.name}",
},
],
"misc": "",
"oscpu": "",
Expand Down